cli/streams: assorted cleanups#6900
Merged
thaJeztah merged 4 commits intodocker:masterfrom Apr 2, 2026
Merged
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
vvoland
reviewed
Apr 2, 2026
Comment on lines
-66
to
-68
| if runtime.GOOS == "windows" { | ||
| return errors.New(eText + ". If you are using mintty, try prefixing the command with 'winpty'") | ||
| } |
Member
Author
There was a problem hiding this comment.
Yeah, I wanted to keep it more generic; the winpty "solution" is really specific to one case (using GitBash or whatsit).
Move the code to the commonStream type, which is where the actual state field is kept. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It's more idiomatic to define the constructor before methods. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Define explicit wrapper methods instead of depending on the embedded commonStreams struct. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
cli_stream_cleanups
branch
from
f7b574f to
0c0cd42
Compare
This function is very specific to attaching to containers, and probably helps clarity to inline it where used. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
cli_stream_cleanups
branch
from
0c0cd42 to
526dfff
Compare
vvoland
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on some related changes, but let's clean this up first
cli/streams: (In|Out).SetRawTerminal: dry
Move the code to the commonStream type, which is where the actual
state field is kept.
cli/streams: move constructors to the start
It's more idiomatic to define the constructor before methods.
cli/streams: don't depend on embedding
Define explicit wrapper methods instead of depending on the embedded
commonStreams struct.
cli/streams: simplify CheckTty and add go:fix to inline it
This function is very specific to attaching to containers, and probably
helps clarity to inline it where used.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)